WIP: Do SROA and DSE in alloc-opt #24478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only remove the call if all of the arguments are eliminated.
* Remove some tag handling code that's not needed anymore
* Put all the states in a struct
There are already too many of them to pass around
and there will likely be even more in the future
yuyichao
added
compiler:codegen
yuyichao
changed the title
yuyichao
force-pushed
the
yyc/codegen/alloc2
branch
from
327dd1b to
97b5666
Compare
This allow us to handle certain object allocations with object reference fields. DSE is particularly useful on LLVM 5.0+ where we can take advantage of llvm store to load forwarding to delete objects that's only used as local buffer. This is also a prototype for the next gen optimization in type inference and to guide the new IR format necessary for it. Fix #16190
yuyichao
force-pushed
the
yyc/codegen/alloc2
branch
from
97b5666 to
426361a
Compare
Merged
Keno
added a commit
that referenced
this pull request
May 7, 2018
|
Merged in #26990. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow us to handle certain object allocations with object reference fields.
DSE is particularly useful on LLVM 5.0+ where we can take advantage of llvm store to load
forwarding to delete objects that's only used as local buffer.
This is also a prototype for the next gen optimization in type inference and to guide
the new IR format necessary for it.
Fix #16190
The first commit is #24475, which was discovered when working on this PR. The second commit should be a NFC clean up.
Currently this may not handle return-twice (try-catch) very well though it also isn't new to this change....